Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Korean translation #201

Merged
merged 6 commits into from Dec 31, 2018

Conversation

Projects
None yet
3 participants
@Johnmacrocraft
Copy link
Contributor

Johnmacrocraft commented Nov 4, 2018

  • This PR actually submits something - don't use this system as a messaging service!
  • This PR isn't duplicated - you can check if it is by scanning the small list - link is on the navigation bar for this repository.
  • This PR includes appropriate markdown for sections - e.g. code blocks for suggested code.
  • This PR description and comments in code is understandable - feel free to use your native language to write if you are not comfortable with English.
  • This PR has a single branch for itself in your fork - don't just commit to the master branch of your repository!
  • This PR has comments written in clear English - please don't write unreadable comments just for your eyes.

Pull Request description

Just a translation submission from a (bored) translator, enjoy! :)

(Ignore branch name, I couldn't translate into Japanese because of laziness, and forgot to rename it. Probably I'll do it later if I have time)

Johnmacrocraft added some commits Nov 4, 2018

oh nvm
I was going to translate this, but I committed without doing that...
@Johnmacrocraft

This comment has been minimized.

Copy link
Contributor Author

Johnmacrocraft commented Nov 4, 2018

It would be appreciated if you make strings for enabled and disabled, instead of hardcoding them in the code, this makes translations weird for (I guess?) most languages

Johnmacrocraft added some commits Nov 4, 2018

@Johnmacrocraft

This comment has been minimized.

Copy link
Contributor Author

Johnmacrocraft commented Nov 4, 2018

@Aericio The pvp.success one.

  • Q1: auto.*
  • Q2: setowner.desc
  • Q3: popup.available
@Johnmacrocraft

This comment has been minimized.

Copy link
Contributor Author

Johnmacrocraft commented Nov 4, 2018

Some issues:

  • Padding won't work properly because of Unicode characters, you'll probably want to fix that if possible
  • /p list doesn't seem to work properly (on most languages)
  • langtemplate can be selected as a language (I don't think someone will do that, but anyway this is not intended)
@Johnmacrocraft

This comment has been minimized.

Copy link
Contributor Author

Johnmacrocraft commented Nov 4, 2018

Question:

  • I'm assuming that the word free in auto strings means something like empty, rather than $0, is that right?
  • By without charging anything, does it mean that players can set owner without paying money? Just in case.
  • Not sure which meaning is better for the word open, I definitely understood the string but still thinking of which one would be the best word to use. What's the exact meaning of that?
@Aericio

This comment has been minimized.

Copy link
Collaborator

Aericio commented Nov 4, 2018

It would be appreciated if you make strings for enabled and disabled, instead of hardcoding them in the code, this makes translations weird for (I guess?) most languages

for when server starts/enables, the messages for them?

also, for the questions, can you show where you mean please? thanks.

@Johnmacrocraft Johnmacrocraft changed the title Add Korean translation Add Korean translation, fix /p list not working properly Nov 4, 2018

@jasonwynn10
Copy link
Owner

jasonwynn10 left a comment

The /p list fix should not be included in this PR.

Show resolved Hide resolved resources/cze.ini Outdated
Show resolved Hide resolved resources/eng.ini Outdated

@Johnmacrocraft Johnmacrocraft changed the title Add Korean translation, fix /p list not working properly Add Korean translation Nov 5, 2018

@Johnmacrocraft

This comment has been minimized.

Copy link
Contributor Author

Johnmacrocraft commented Nov 5, 2018

As I reverted my changes to other language files and the questions from the above have been resolved, you can merge this now.

@jasonwynn10 jasonwynn10 merged commit f2591da into jasonwynn10:master Dec 31, 2018

1 check passed

poggit-ci/myplot Created PR build #67 (&51626): Lint passed
Details
@Aericio

This comment has been minimized.

Copy link
Collaborator

Aericio commented Dec 31, 2018

lmao that wasn't a month late

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.