Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bower support & more #1

Closed
5 tasks done
henryruhs opened this issue May 20, 2015 · 6 comments
Closed
5 tasks done

Add bower support & more #1

henryruhs opened this issue May 20, 2015 · 6 comments

Comments

@henryruhs
Copy link

  • Please add bower support to your repository and register the project
  • Please add " ifvisible.js" as dependency, never put third party libs into your repository.
  • Please create a tag
  • Please correct the typo in TImeMe.js to TimeMe.js
  • Update the API from clear_ to reset_ inside the README.md

Thanks

@jasonzissman
Copy link
Owner

Thanks for the pointers. I'll be taking care of all of these later this weekend!

@henryruhs
Copy link
Author

Great!

I also suggest to:

  • Use type safe === inside your if clauses
  • Use parseFloat() for the timer to force the number type

@henryruhs henryruhs changed the title Add bower support Add bower support & more May 26, 2015
@henryruhs
Copy link
Author

Good work so far, but...

  1. clearRecordedPageTime is still in README.md ...
  2. TimeMe.getTimeOnPageInSeconds still returns numbers as string

@jasonzissman
Copy link
Owner

As always, thanks for the tips! I am going to do some Bower investigation now, and will hopefully get around to properly introducing it (and tagging TimeMe, and reference ifvisible) today!

@jasonzissman
Copy link
Owner

I've added Bower Support and registered it with Bower. I thank you for the help, it is much appreciated! If you notice anything still wrong (very likely - I am new to Bower), please let me know!

@henryruhs
Copy link
Author

Don't be shy with your 0.0.0 tag ... it is worth the 1.0.0 :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants