Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept RegisterCommand(typeof(T)) #26

Closed
joaofx opened this issue Jul 25, 2019 · 2 comments
Closed

Accept RegisterCommand(typeof(T)) #26

joaofx opened this issue Jul 25, 2019 · 2 comments
Milestone

Comments

@joaofx
Copy link

joaofx commented Jul 25, 2019

Hi!

First of all, super cool library. Thanks for sharing it.

Currently, it seems there is two ways to register commands on CommandFactory::

RegisterCommand<T>()
RegisterCommands(Assembly assembly)

I need register by Type not using generics.

RegisterCommand(typeof(T))

Would you accept a pull request for that?

Thanks again.

@jeremydmiller
Copy link
Member

@joaofx Hey, sorry I missed this. I would accept a PR, but I'm in the code this week and I can do that pretty quickly.

@jeremydmiller jeremydmiller added this to the 2.0 milestone Aug 26, 2019
@joaofx
Copy link
Author

joaofx commented Aug 26, 2019

Uhhh that's awesome! Thanks a million!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants