Updated Choice type to allow for multiple choices #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…compatible with the multiple attribute for select elements
… vague exceptions regarding unsafe use of head or !!
|
Looks good to me. Would it be possible to add a test as well though? Thanks for your work @cimmanon! |
|
Do you have any ideas for one that will fit the Pokemon theme? |
|
Maybe selecting a number of Pokemon that the user likes? |
|
There, I've added a test that allows you to set multiple weaknesses for a Pokemon. |
cimmanon
force-pushed
the
choice-multiple
branch
from
c3c0f5f
to
a29dbea
Compare
|
Hm, commit 26e6ce5 is causing the "choice expects a list with at least one item in it" error to be emitted in one of my forms that fetches the choice options from the database. Closing this until I can figure out where the problem is. |
cimmanon
force-pushed
the
choice-multiple
branch
from
673b7f1
to
54f21b1
Compare
|
This looks great now. Thanks for all the work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Choicenow takes a list of selected values rather than a single value. This allows themultipleattribute to be used for select elements when using one of the 8 new formlet functions. It can potentially be used to generate a list of checkboxes within View generating libraries (Heist, Blaze, etc.) as well.This directly addresses the following issues:
And indirectly or partially addresses the following issues: