Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remember opened "sub-folders" #25

Open
fredefox opened this issue Oct 23, 2018 · 4 comments
Open

Remember opened "sub-folders" #25

fredefox opened this issue Oct 23, 2018 · 4 comments

Comments

@fredefox
Copy link

In the HTML output I think it would be super useful if folding a parent folder with multiple open children would remember what children are opened. Would this be reasonably easy to add? Are you open for PRs? I might be interested in working on it. Would be great if you could point me in the right direction to get started.

Thanks for the tool!

@fredefox
Copy link
Author

I see that the children are added to the DOM only when a folder is expanded and removed again when it is closed. So perhaps this is not so straight forward.

Is there a specific reason that not everything is added to the dom on the initial page load? I'm guessing there might be a great deal of HTML that would need to be generated for large profiler outputs...

@jaspervdj
Copy link
Owner

Yes, adding all of the children is not really possible for large enough profiler outputs, the browser will just end up freezing.

I don't see anything wrong with keeping the children around when closing the parent though.

@fredefox
Copy link
Author

Cool. So we would need to modify the close-operation to simply just hide the html element and then we need to modify the open operation to check if the subfolder has already been generated.

@fredefox
Copy link
Author

Sounds easy enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants