Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Have 100% of test coverage #28

Closed
jaswdr opened this issue Oct 9, 2020 · 5 comments
Closed

[FEATURE] Have 100% of test coverage #28

jaswdr opened this issue Oct 9, 2020 · 5 comments
Labels
enhancement New feature or request hacktoberfest

Comments

@jaswdr
Copy link
Owner

jaswdr commented Oct 9, 2020

Is your feature request related to a problem? Please describe.
This is an improvement on our current test coverage.

Describe the solution you'd like
Recently we have added the test coverage report, considering that this project is focused in generate fake data for tests, is good to have 100% of test coverage.

Describe alternatives you've considered
For normal projects, it's common knowledge that 100% don't guarantee quality, but in this case this project is focused on tests, so is important to us to have at minimum a good test coverage.

Additional context
The confirmation that we reach this goal is having 100% in coveralls

Important! Use the full-tests-coverage branch as target of pull requests.

@jaswdr jaswdr added enhancement New feature or request hacktoberfest labels Oct 9, 2020
@ab22
Copy link
Contributor

ab22 commented Oct 13, 2020

Would you prefer to have these on one big PR? I took a quick glance at what's missing but I'm not sure how big the end change would be. Also, I would like to start working on these but I would also like to have a better control on what's taken and what's not in case more people wants to collaborate.

@jaswdr
Copy link
Owner Author

jaswdr commented Oct 13, 2020

@ab22 I guess one approach that we can do to split the work is to fix each file individually, doing PR's for each file adding a 100% coverage for only that one.

what you think?

@ab22
Copy link
Contributor

ab22 commented Oct 13, 2020

Sounds good 👍. I will start with the person.go tests in that case and will keep calling out which file I'm picking up.

@ab22
Copy link
Contributor

ab22 commented Oct 21, 2020

@jaswdr Once PR #33 gets approved and merged, I will start working on payment.go.

@jaswdr
Copy link
Owner Author

jaswdr commented Oct 21, 2020

@ab22 sorry for the delay, I've reviewed and commented there 👍

@jaswdr jaswdr closed this as completed Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hacktoberfest
Projects
None yet
Development

No branches or pull requests

2 participants