Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build error #15

Closed
jeffslofish opened this issue Jul 7, 2019 · 2 comments
Closed

Build error #15

jeffslofish opened this issue Jul 7, 2019 · 2 comments

Comments

@jeffslofish
Copy link

After doing a git clone and then running yarn I attempted to run npm run build-chrome per the contributing instructions and I get errors, beginning with:

[2] [19:50:56] Starting 'clean'...
[2] [19:50:56] The following tasks did not complete: clean
[2] [19:50:56] Did you forget to signal async completion?
[2] events.js:174
[2]       throw er; // Unhandled 'error' event
[2]       ^
[2] 
[2] Error: ENOENT: no such file or directory, open './dist/manifest.json'

I noticed that if I created the "dist" directory manually, then the error goes away and traced the problem to line 33 in webpack.config.js which is assuming that the ${WORKDIR} directory exists, which is "dist" in this case.

  .pipe(fs.createWriteStream(`./${WORKDIR}/manifest.json`));

It would be nice if the "dist" directory was automatically created if it doesn't exist, so that the first time you try to build it won't fail, since the "dist" directory is not included in the repo.

I could create a pull request to fix this if you like.

@jaszhix
Copy link
Owner

jaszhix commented Jul 7, 2019

Hi, good catch. I can fix this, or you can PR. Either works. Thanks.

@jeffslofish
Copy link
Author

Why don't you go ahead and fix it. I looked into it and there are a few different ways to do it and I wasn't sure which you would like the best.

@jaszhix jaszhix closed this as completed in 80a97a2 Jul 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants