Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Degrade scales up very quickly #165

Closed
SomeoneCalledRob opened this issue Mar 30, 2021 · 5 comments · Fixed by #177
Closed

Degrade scales up very quickly #165

SomeoneCalledRob opened this issue Mar 30, 2021 · 5 comments · Fixed by #177
Milestone

Comments

@SomeoneCalledRob
Copy link

The Depth control of the Degrade section scales the effect up pretty quickly if the Amount value is anything beyond a low number. Sometimes it's nice to have some barely detectable tape hiss on the master -- barely detectable even when wearing headphones. So my preference would be finer control over lower depth values, if possible.

@jatinchowdhury18
Copy link
Owner

That's a good point... It's important to be clever about how to implemen this though, since I'd rather not break existing settings that people have saved. I'm thinking the best option might be to have a multiplier parameter, that multiplies the Depth value by 0.1 or something like that. I'll give that a try and see how well it works.

@jatinchowdhury18 jatinchowdhury18 added this to the 2.8.0 Release milestone Mar 31, 2021
@SomeoneCalledRob
Copy link
Author

Thanks, that would probably work for me.

@jatinchowdhury18 jatinchowdhury18 linked a pull request Apr 5, 2021 that will close this issue
@jatinchowdhury18
Copy link
Owner

This feature has now been implemented, and can be tested in the nightly builds. Big thanks to @NeelKanth333 for helping with the implementation!

@SomeoneCalledRob
Copy link
Author

Just tested. It's much better and would even work as the default, with a button marked x10 to be engaged for more extreme settings. I've been trying it on a quiet, ambient-style track and even with the new 0.1x mode, I run it at low settings. But that's fine, as long as it works, which it does. Thanks again.

@jatinchowdhury18
Copy link
Owner

Great! Yeah, I tried it out in a couple mixes, and you're definitely right that the "just barely audible" hiss can be super useful. So thanks for the idea!

I think I'd prefer to keep the default behaviour as is, again just to avoid breaking saved settings that people currently have with the plugin. But I'll take some time to think about it and see if there's some way to compromise on that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants