Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New release with aarch64 build fix #243

Closed
Bleuzen opened this issue Jan 23, 2022 · 2 comments
Closed

New release with aarch64 build fix #243

Bleuzen opened this issue Jan 23, 2022 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@Bleuzen
Copy link

Bleuzen commented Jan 23, 2022

Hi, as you may remember there were arm build issues discussed in #236.
This is fixed now, but only on master branch.
However for flathub I usually only build from tags as this is what works with the update checker. Currently, while building from git master, the update checker is somewhat confused and suggests downgrades to the v2.10.0 tag.
A new fix release (2.10.1) would help with that.
Thanks :)

@Bleuzen Bleuzen added the enhancement New feature or request label Jan 23, 2022
@jatinchowdhury18
Copy link
Owner

Hi! Yes, I can definitely see how that would be helpful for packaging. Unfortunately, whenever I tag a release on GitHub, everyone who uses the plugin will see a screen asking them if they would like to update to the latest release the next time they open it. For that reason, I try to avoid tagging releases, except when there are new features/big fixes that folks can enjoy when they install the new version.

I wonder if this issue could be avoided via the "meta" repository we were discussing... that way we can tag releases in that repo whenever any plugin is updated and it won't affect the individual plugin repos?

@Bleuzen
Copy link
Author

Bleuzen commented Jan 24, 2022

Okay can see the problem here, didn't know the plugin has a built in update checker. In this case let's not annoy all the users with a new release which doesn't bring anything new to the table.

The meta repo could indeed solve it in this case so let's focus on that. I commented now on that corresponding issue.
Thanks a lot for working on this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants