Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Labels do not scale with UI #259

Closed
hellocatfood opened this issue Apr 26, 2022 · 9 comments
Closed

[BUG] Labels do not scale with UI #259

hellocatfood opened this issue Apr 26, 2022 · 9 comments
Assignees
Labels
bug Something isn't working gui

Comments

@hellocatfood
Copy link

Describe the bug
When the plugin UI is rescaled the controls (knobs/faders) get lager but the text labels stay the same. This is particularly a problem when the UI is rescaled on HiDPI screens to make it more usable/legible.

To Reproduce
Steps to reproduce the behavior:

  1. Grab the corner of the plugin window
  2. Resize to make it larger
  3. See error (text labels stay the same size)

Expected behavior
Text should resize with the UI

Screenshots
Below is the plugin UI shown at its default size when opened in Carla on a HiDPI screen (3840x2400)

Screenshot from 2022-04-26 22-24-11

Below is the same plugin resized to fill most of the same screen.

Screenshot from 2022-04-26 22-24-26

Desktop (please complete the following information):

  • OS: Ubuntu 21.10
  • DAW: Carla
  • Version: 2.4.3
@hellocatfood hellocatfood added the bug Something isn't working label Apr 26, 2022
@jatinchowdhury18
Copy link
Owner

Thanks for reporting the issue! it definitely looks like we can do better when scaling up on higher resolution screens. There's a few things that I'm noticing from the screenshots, but please chime in if there's more things that you've noticed:

  • top/bottom bar are too small
  • "tabs" are too small
  • rotary sliders are too large and knob labels are too small
  • linear sliders are too small
  • some buttons (stereo, flutter sync) are too small
  • tape speed buttons seem to be the correct size, but the text is too small

I also wonder if there's something about the way that Carla handles the window sizing and scale factor that could make this situation worse. Would it be possible to try running the plugin in "Standalone" mode to see if the scaling problem happens the same way?

I don't have a HiDPI monitor to test on at the moment, so I may need a little bit of help with testing, but I'll update this thread with any progress on the issue!

@hellocatfood
Copy link
Author

What's the terminal command to run this plugin in standalone mode?

For reference I think this problem exists across all Chow plugins. I ran ChowKick and this is the size that it opened up at.

Screenshot from 2022-04-27 10-15-38

After resizing to fit the whole screen the labels don't resize

Screenshot from 2022-04-27 10-15-51

@jatinchowdhury18
Copy link
Owner

The standalone plugin will be located in build/CHOWTapeModel_artefacts/Release/Standalone/... if you're building from source, or in /usr/bin/... if you're using the .deb installer. If you're installing from a different package, then I'm not totally sure where the standalone will be located.

I'm using the same UI framework for all our plugins, so I'm not surprised that the same issue shows up in multiple plugins. That said, hopefully if we fix the issue in one plugin, the same fix should translate pretty easily to the others as well!

@hellocatfood
Copy link
Author

hellocatfood commented May 3, 2022

if you're building from source, or in /usr/bin/... if you're using the .deb installer.

I installed the deb from your website. What is the binary called? Running ls | grep Chow in /usr/bin/ only brings up ChowKick

@jatinchowdhury18
Copy link
Owner

The name of the binary should be CHOWTapeModel (or ChowKick for the other plugin). I guess the capital letters might not be caught in the grep search? Although I suppose depending on how the debian package was installer, the binary could end up in ~/usr/bin/... instead.

@hellocatfood
Copy link
Author

Thanks for that. I was able to load the plugin and, as expected, the issue still exists.

@jatinchowdhury18
Copy link
Owner

Hi there! Sorry it's taken so long to get back to this. We've made some improvements in #281, and it would be great to know how things are looking on your screen with the latest nightly build.

@hellocatfood
Copy link
Author

all seems to be working now!
Screenshot from 2022-07-10 18-44-43
Screenshot from 2022-07-10 18-45-02
Screenshot from 2022-07-10 18-45-15

@jatinchowdhury18
Copy link
Owner

Awesome! Thanks again for reporting and testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working gui
Projects
None yet
Development

No branches or pull requests

2 participants