Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Improve input clipping behavior #81

Closed
jatinchowdhury18 opened this issue Sep 7, 2020 · 1 comment
Closed

[FEATURE] Improve input clipping behavior #81

jatinchowdhury18 opened this issue Sep 7, 2020 · 1 comment
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@jatinchowdhury18
Copy link
Owner

Is your feature request related to a problem? Please describe.
Currently, the input signal is clipped before being input to the hysteresis model (see here). This clipping is meant to protect the hysteresis model from going unstable, but can cause undesirable distortion at extreme input gains.

Describe the solution you'd like
Fine-tune the clipping values for each ODE solver and oversampling amount so that the input is only clipped when on the verge of causing an instability.

Additional context
Depending on the results of the fine-tuning, maybe add an "unsafe mode" option to turn of input clipping all together.

@jatinchowdhury18 jatinchowdhury18 added the enhancement New feature or request label Sep 7, 2020
@jatinchowdhury18 jatinchowdhury18 added this to the v2.6 milestone Sep 7, 2020
@jatinchowdhury18 jatinchowdhury18 self-assigned this Sep 7, 2020
@jatinchowdhury18
Copy link
Owner Author

jatinchowdhury18 commented Sep 29, 2020

Fixed with 19ec0de.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant