Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Improve parameter sliders in Loss section #91

Closed
jatinchowdhury18 opened this issue Oct 3, 2020 · 2 comments · Fixed by #103
Closed

[BUG] Improve parameter sliders in Loss section #91

jatinchowdhury18 opened this issue Oct 3, 2020 · 2 comments · Fixed by #103
Assignees
@jatinchowdhury18
Labels
bug Something isn't working
Milestone
v2.7

Comments

@jatinchowdhury18
Copy link
Owner

Describe the bug
The units for the loss effect parameters currently reads "cm". Double check that this is correct, and fix it if not.
@jatinchowdhury18 jatinchowdhury18 added the bug Something isn't working label Oct 3, 2020
@jatinchowdhury18 jatinchowdhury18 self-assigned this Oct 3, 2020
@jatinchowdhury18 jatinchowdhury18 added this to the v2.7 milestone Oct 3, 2020
@jatinchowdhury18 jatinchowdhury18 changed the title [BUG] Double check loss effect units [BUG] Improve parameter sliders in Loss section Oct 4, 2020
@jatinchowdhury18
Copy link
Owner Author

jatinchowdhury18 commented Oct 4, 2020 •
edited
Loading

More from KVR:

  • please consider using mm units (instead of cm) for the "loss" section parameters, as it would avoid having to type 0.00000000014 values ;)

@jatinchowdhury18 jatinchowdhury18 linked a pull request Oct 25, 2020 that will close this issue
Correct loss slider values for cm units #103
Merged
@jatinchowdhury18
Copy link
Owner Author

It appears that the although existing code labelled the loss parameters as "centimeters" (1/100 of a meter), the actual values being shown were "decentimeters" (1/10 of a meter). I've now fixed this, so the sliders are still labelled as "centimeters", but the actual values displayed are physically correct centimeters. The advantage of this is that users get an extra decimal point, and should never have to type more than three zeros when entering a value.

@bobobo199733 bobobo199733 mentioned this issue Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jatinchowdhury18 jatinchowdhury18

Labels
bug Something isn't working
Projects
None yet
Milestone
v2.7
Development

Successfully merging a pull request may close this issue.

Correct loss slider values for cm units jatinchowdhury18/AnalogTapeModel
1 participant
@jatinchowdhury18