Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Possibility to define a round with no passes #57

Closed
jatkinson1000 opened this issue Feb 3, 2024 · 0 comments · Fixed by #84
Closed

Bug: Possibility to define a round with no passes #57

jatkinson1000 opened this issue Feb 3, 2024 · 0 comments · Fixed by #84
Labels
bug Something isn't working
Milestone
First Release to ...

Comments

@jatkinson1000
Copy link
Owner

It is possible to define a round with no passes leading to undefined behaviour when subsequently used.
It is unlikely one would do this intentionally, but perhaps there should be a check that the input parameter is a list of Pass (or a single Pass?).
@jatkinson1000 jatkinson1000 added the bug Something isn't working label Feb 3, 2024
This was referenced Mar 7, 2024
Closed
Merged
@jatkinson1000 jatkinson1000 added this to the First Release to PyPI milestone Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
First Release to PyPI
Development

Successfully merging a pull request may close this issue.

Prevent empty Round passes and type guarding jatkinson1000/archeryutils
1 participant
@jatkinson1000