Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generate more data #109

Open
Chris-Lea opened this issue Oct 12, 2022 · 0 comments
Open

generate more data #109

Chris-Lea opened this issue Oct 12, 2022 · 0 comments

Comments

@Chris-Lea
Copy link

Chris-Lea commented Oct 12, 2022

Two points in my view could make the project more perfect. Welcome discussion and correction if I was wrong.

  1. When scrolling the window, the last one timestep is forgotten. It could add 1 the for loop in line26 and line45 to add 1 sample, like this "range(self.len_test - seq_len+1)".
  2. Rather than scrolling the window in train and test dataset respectively, I think it could be better scrolling the window first and split the train and test dataset. This could add 50 (one seq_len) samples.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant