Need to get raw text from DiffRow

[rosta]

Code snippet

	DiffRowGenerator generator = DiffRowGenerator.create()
			.showInlineDiffs(true)
			.mergeOriginalRevised(false)
			.inlineDiffByWord(true)
			.oldTag(f -> "~~")
			.newTag(f -> "**")
			.ignoreWhiteSpaces(true)
			.build();
	List<DiffRow> rows = generator.generateDiffRows(content1, content2);
	int line = 1;
	for (DiffRow row : rows) {
		if (isIncluded(row)) {
			// Write out the markdown ...
		}
		line++;
	}

The function isIncluded() is implemented as

	private boolean isIncluded(DiffRow row) {
		if ( row.getTag() == Tag.EQUAL) {
			return false;
		}
		return excludePatterns.stream()
				.noneMatch(p -> p.matcher(row.getOldLine()).find()
						|| p.matcher(row.getNewLine()).find());
	}

where excludePatterns is a list of compiled regular expressions provided by the user.

Challenge

The pattern is matched on the formatted lines, so the user has to provide regular expressions such as
\* <dt>Generated</dt><dd>[0-9 :~*-]*</dd>
rather than
\* <dt>Generated</dt><dd>[0-9 :-]*</dt>
which is more readable and less error prone.

In matter of fact the first regular expression doesn't work in any case because the markdown tag falls in the middle of the </dd> tag. For example:

<dd>2019-07-**26** **05:00<**/dd>

NB I could have used the reportLinesUnchanged(boolean) builder config, but then I would lose the formatted lines which are used to output markdown code. (See the comment below as well)

Request

Provide methods in the DiffRow
public String getRawOldLine()
and
public String getRawNewLine().

(By the way many thanks for this library, it's been very useful)

[rosta]

It appears that the configuration reportLinesUnchanged has no effect when showInlineDiffs is true. That is '<' and '>' characters are converted to HTML entities regardless.

[wumpz]

That is right. However, this option should be optional. It will double the needed memory of each line.

I will look into it but do not have much time at the moment.

[rosta]

I agree completely that it should be optional.

Pull request with a possible implementation has been opened for review.

[github-actions]

Stale issue message