Deprecate EventLogRecord#getEventId in favor of #getInstanceId

[dbwiddis]

The terms "Event ID" and "event identifier" refer to different things, which leads to confusion and probably led to .NET deprecating the former term. JNA should do the same.

[dblock]

We don't seem to have tests for these, but maybe we can make some assumptions about the values returned from these methods in https://github.com/java-native-access/jna/blob/cc1acdac02e4d0dda93ba01bbe3a3435b8933dab/contrib/platform/test/com/sun/jna/platform/win32/Advapi32UtilTest.java? Ideally I'd want tests to describe something similar to http://balazsberki.com/2017/02/reading-the-windows-event-log-event-id-problems-with-qualifiers/ in.

Merge on 🍏 either way.

[dbwiddis]

I think I can throw something together with some well-known ID types, e.g, event log started (6005) will be an info type with Instance ID -2147477643 (technically the positive value).

Actually that brings up another question: in .NET the Instance ID is a 64-bit number. Should we make that a long? (To be clear, it's a 32-bit unsigned integer...)

[dbwiddis]

So I just added a test to search for the "Event Log started" event in the system log. But I also notided in Advapi32UtilTest the testReportEvent() method actually creates an event entry in the log that we could look for. It currently uses the event ID of 0 but we could customize that for our tests... I'll rework that.

[dblock]

👍