Add or extend structures needed to read HKEY_PERFORMANCE_DATA #980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbwiddis
force-pushed
the
master
branch
5 times, most recently
from
d69a8ce
to
8a4c5c3
Compare
| public int CounterNameTitle; // always 32 bit | ||
| public int CounterHelpTitleIndex; | ||
| public int CounterHelpTitle; // always 32 bit | ||
| public NativeLong DefaultScale; |
There was a problem hiding this comment.
In the header this is:
LONG DefaultScale;
the other encounters of LONG are mapped to int (according to windows definition LONG is a 32 bit integer)
There was a problem hiding this comment.
OK, I've bookmarked this page so I'll stop guessing...
|
|
||
| // PERF_DATA_BLOCK test | ||
| // Test the signature, a char[] containing [P, E, R, F] | ||
| PERF_DATA_BLOCK perfData = new PERF_DATA_BLOCK(pPerfData.share(0)); |
There was a problem hiding this comment.
Why the share(0) and not directly pass in the pPerfData? Is this for consistency with the following share calls?
There was a problem hiding this comment.
My intent was to highlight the fact that the PERF_DATA_BLOCK is only the first portion of the allocated pPerfData memory. So there was somewhat of a consistent approach with that vs. the other calls. I agree that it's not necessary, however, and I'll remove it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.