Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add @Ignore to internal/intermediate DependentResources #1292

Merged
merged 1 commit into from Jun 17, 2022

Conversation

metacosm
Copy link
Collaborator

The goal is to allow downstream processes (e.g. the Quarkus extension)
which might need to introspect only user-defined DependentResource
implementations, similarly to what was done for Reconciler
implementations already.

The goal is to allow downstream processes (e.g. the Quarkus extension)
which might need to introspect only user-defined DependentResource
implementations, similarly to what was done for Reconciler
implementations already.
@metacosm metacosm self-assigned this Jun 17, 2022
@metacosm metacosm requested a review from csviri June 17, 2022 13:57
@sonarcloud
Copy link

sonarcloud bot commented Jun 17, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Collaborator

@csviri csviri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@metacosm metacosm merged commit d99f65a into main Jun 17, 2022
@metacosm metacosm deleted the ignore-internal-dr-implementations branch June 17, 2022 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants