-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: improvements on informer start and logging #1749
Conversation
}).collect(Collectors.toList())).forEach(f -> { | ||
try { | ||
// to find out any exceptions | ||
f.get(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this defeating the purpose? I mean this will block each callable in turn…
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those callables are already finsihed that time. (At least if I correctly understand the javadocs of invoke all :) )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yes, you are right!
Kudos, SonarCloud Quality Gate passed! |
No description provided.