feat: use processors for matching as well since usually both are related #1911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
metacosm
commented
May 23, 2023
metacosm
commented
- feat: use processors for matching as well since usually both are related
- refactor: remove unneeded parameter that can also be inferred from DR
csviri
approved these changes
May 23, 2023
|
Kudos, SonarCloud Quality Gate passed! |
|
Just one note something like this I wanted to do also for 4.4, not sure if we should have a higher level concept for this explicitly. But I think it is ok now, we cant iterate on it for next minor release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.