Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: not start operator if leader elector has no permission to lease object #1912

Merged
merged 10 commits into from May 24, 2023
Merged

feat: not start operator if leader elector has no permission to lease object #1912

merged 10 commits into from May 24, 2023

Conversation

csviri
Copy link
Collaborator

@csviri csviri commented May 23, 2023

No description provided.

@csviri csviri self-assigned this May 23, 2023
@csviri csviri linked an issue May 23, 2023 that may be closed by this pull request
RuntimeInfo reports started even if leader elector cannot access lease #1903
Closed
@csviri
Copy link
Collaborator Author

csviri commented May 23, 2023

will check how elegantly can check other permission (put) on the resources

@csviri csviri requested a review from metacosm May 23, 2023 12:49
@csviri csviri changed the title feat: stops operator if leader elector has no permission to lease object feat: not start operator if leader elector has no permission to lease object May 24, 2023
@sonarcloud
Copy link

sonarcloud bot commented May 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

17.2% 17.2% Coverage
0.0% 0.0% Duplication

metacosm
metacosm approved these changes May 24, 2023
View reviewed changes
Copy link
Collaborator

@metacosm metacosm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't know enough about leader election to have an informed opinion, so trusting you on this :)

@metacosm metacosm merged commit 81090a6 into main May 24, 2023
19 checks passed
@metacosm metacosm deleted the stop-le-issue branch May 24, 2023 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@metacosm metacosm metacosm approved these changes

Assignees

@csviri csviri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RuntimeInfo reports started even if leader elector cannot access lease
2 participants
@csviri @metacosm