Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci): use Java 17 #559

Merged
merged 2 commits into from
Oct 8, 2021
Merged

chore(ci): use Java 17 #559

merged 2 commits into from
Oct 8, 2021

Conversation

metacosm
Copy link
Collaborator

No description provided.

@metacosm
Copy link
Collaborator Author

2 options:

  • Either only run on Temurin JDKs
  • Wait for OpenJ9 to release a Java 17 JDK

@metacosm metacosm mentioned this pull request Sep 29, 2021
Closed
iocanel
iocanel approved these changes Oct 5, 2021
View reviewed changes
Copy link
Collaborator

@iocanel iocanel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@metacosm metacosm marked this pull request as ready for review October 8, 2021 07:20
@metacosm
Copy link
Collaborator Author

metacosm commented Oct 8, 2021

Let's go ahead and focus solely on Temurin for now… Would be nice if we could have more control over the distribution x version matrix so that we could say use version 11 & 17 for Temurin and only 11 for OpenJ9 but 🤷🏼

@metacosm metacosm merged commit 98e3def into master Oct 8, 2021
@metacosm metacosm deleted the java-17 branch October 8, 2021 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iocanel iocanel iocanel approved these changes

@csviri csviri csviri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@metacosm @iocanel @csviri