refactor!: replace Closeable by explicit Stoppable interface #633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metacosm
force-pushed
the
replace-closeable
branch
from
ad745d7
to
99626cb
Compare
Closed
csviri
reviewed
Oct 28, 2021
|
|
||
| import io.javaoperatorsdk.operator.OperatorException; | ||
|
|
||
| public interface Stoppable { |
There was a problem hiding this comment.
Maybe have a name that describes that there is also Start, like LifecycleHandler or sych.
There was a problem hiding this comment.
Yeah, was wondering what a good name would be :) How about LifecycleAware?
This ensures that stoppable classes can also be started if needed. Fixes #629
metacosm
force-pushed
the
replace-closeable
branch
from
8701d61
to
e33417d
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that stoppable classes can also be started if needed.
Fixes #629