Support Standard Kuberentes Resources not just CustomResource #678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csviri
changed the title
# Conflicts: # operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/internal/CustomResourceEventSource.java
additinal fixes , renamings
# Conflicts: # operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/Cloner.java # operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/ConfigurationService.java
metacosm
approved these changes
Nov 19, 2021
...ework-core/src/main/java/io/javaoperatorsdk/operator/api/config/ControllerConfiguration.java
Outdated
Show resolved
Hide resolved
…erator-sdk into support-non-cr
metacosm
reviewed
Nov 22, 2021
| @@ -30,15 +30,14 @@ | |||
| @Test | |||
| public void testReconciliationOfNonCustomResourceAndStatusUpdate() { | |||
| var deployment = operator.create(Deployment.class, testDeployment()); | |||
| await().atMost(10, TimeUnit.SECONDS).untilAsserted(() -> { | |||
| await().atMost(15, TimeUnit.SECONDS).untilAsserted(() -> { | |||
There was a problem hiding this comment.
Why is it taking longer now, though?
There was a problem hiding this comment.
trying something, just on one kubernetes version in tests sometimes fails. And it looks like for a timeout for retry after a conflict. But still working on it to figure it out
There was a problem hiding this comment.
It seems that the problem is with namespace deletion, not with the actual test logic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.