API changes proposal #760
Merged
API changes proposal #760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csviri
reviewed
Dec 16, 2021
...work-core/src/main/java/io/javaoperatorsdk/operator/processing/event/source/EventSource.java
Outdated
Show resolved
Hide resolved
csviri
reviewed
Dec 16, 2021
...a/io/javaoperatorsdk/operator/processing/event/source/controller/UpdatableResourceCache.java
Outdated
Show resolved
Hide resolved
csviri
reviewed
Dec 16, 2021
...e/src/main/java/io/javaoperatorsdk/operator/processing/event/source/EventSourceRegistry.java
Outdated
Show resolved
Hide resolved
csviri
reviewed
Dec 16, 2021
| @@ -69,4 +67,9 @@ public void stop() throws OperatorException { | |||
| super.stop(); | |||
| cache.close(); | |||
| } | |||
|
|
|||
| @Override | |||
| public T getAssociated(P primary) { | |||
There was a problem hiding this comment.
Why it needs the whole resource? I think this should be ideally as simple as possible API and just use the ResourceID
There was a problem hiding this comment.
It's just generalizing the method that's already present on InformerEventSource. This method will always be called in a context where the primary is available anyway so why restrict it to only providing the ResourceID?
There was a problem hiding this comment.
not sure how we agreed on this, I still think it should be ResourceID :)
csviri
reviewed
Dec 16, 2021
| import static org.mockito.Mockito.mock; | ||
| import static org.mockito.Mockito.when; | ||
|
|
||
| public class AbstractEventSourceTest<S extends EventSource, T extends EventHandler> { |
There was a problem hiding this comment.
This should be a Junit extension, as for Integration tests. I think there should be no inheritance in unit tests.
There was a problem hiding this comment.
Feel free to change that.
metacosm
force-pushed
the
api-changes
branch
from
a30229a
to
2ac5c00
Compare
This makes the intent clearer: the `EventSourceInitializer` prepares `EventSource`s that the SDK then registers automatically, without the reconciler having to call the register method in `prepareEventSources`. This also allows for removing the `EventSourceRegistry` interface altogether.
metacosm
force-pushed
the
api-changes
branch
from
c19529b
to
7dd8a64
Compare
csviri
reviewed
Dec 21, 2021
...rk-core/src/main/java/io/javaoperatorsdk/operator/api/reconciler/EventSourceInitializer.java
Outdated
Show resolved
Hide resolved
csviri
approved these changes
Dec 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.