Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Optional associated resource #793

Merged
merged 3 commits into from
Jan 5, 2022
Merged

Conversation

csviri
Copy link
Collaborator

@csviri csviri commented Jan 5, 2022

To make it consistent with other Optional APIs.

@csviri csviri self-assigned this Jan 5, 2022
@@ -36,6 +37,7 @@
import static org.mockito.Mockito.when;

@EnableKubernetesMockClient(crud = true, https = false)
@Disabled
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't have been committed…

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes :/ will remove it

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

@csviri csviri requested a review from metacosm January 5, 2022 10:42
@csviri csviri merged commit 4088a3c into main Jan 5, 2022
@csviri csviri deleted the optional-associated-resource branch January 5, 2022 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants