Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proposal] HTTP/2 Client APIs #74

Open
joshaustintech opened this issue Mar 26, 2024 · 8 comments
Open

[Proposal] HTTP/2 Client APIs #74

joshaustintech opened this issue Mar 26, 2024 · 8 comments

Comments

@joshaustintech
Copy link

Request Issue

#8

Website Section

Home --> Tutorials --> HTTP Client

Proposal Details

  • Why this API and not other HTTP clients?
    • Lightweight
    • No dependencies
  • Fetching recipe data from TheMealDB
    • Building an HttpClient
    • Building an HttpRequest
    • Getting an HttpResponse
      • Method 1: synchronous
      • Method 2: asynchronous

Author References

@joshaustintech
Copy link
Author

Hi @carimura, @nipafx, I'm new to this process. Anything I you need from me?

@carimura
Copy link
Member

carimura commented Apr 3, 2024

Thanks for the submission and sorry for delay, I've been on paternity leave. Looks straightforward. "Why this API" seems good but I would avoid going too far into the "why not other HTTP clients". The rest seems fun.

Thoughts @nipafx @JosePaumard ?

@joshaustintech
Copy link
Author

@carimura congrats on the new arrival!

@nipafx
Copy link
Contributor

nipafx commented Apr 15, 2024

Hey @joshaustintech , thanks for the proposal. It looks good! Some comments:

  • The website section should be https://dev.java/learn/ -> Mastering the API
  • I recommend to start with the tutorial (your second bullet point) and come to reasons for using this API (your first bullet point) later - this way the article starts with what people are most likely to be searching for.
  • When discussing the synchronous approach, please bring up virtual threads and link to the respective article.
  • Let's not use MealDB. I'd have to take a closer look at the website to verify that it can feature in our tutorials. Instead, let's use dev.java or inside.java.
  • In case you need inspiration, feel free to check the two posts I wrote on this API: 1, 2

Feel free to open a PR once you've got something to review. Note that I'll be out of office unitl early May, though, so no need to rush. 😉

@joshaustintech
Copy link
Author

Sounds great. Thanks @nipafx. 😎

@carimura
Copy link
Member

Hi @joshaustintech just going through open issues -- did you want to open a PR for this? We are happy to review as soon as that's in. and thanks!

@joshaustintech
Copy link
Author

Yes, I would love to open a PR soon as I have the content ready in the next few weeks.

@joshaustintech
Copy link
Author

Thank you all for your patience, still planning to open a PR for this soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants