Skip to content
This repository has been archived by the owner on Sep 5, 2023. It is now read-only.

Generic Passthru Elements #1111

Closed
glassfishrobot opened this issue May 30, 2012 · 22 comments
Closed

Generic Passthru Elements #1111

glassfishrobot opened this issue May 30, 2012 · 22 comments

Comments

@glassfishrobot
Copy link

Generic Passthru Elements

@glassfishrobot
Copy link
Author

Reported by @edburns

@glassfishrobot
Copy link
Author

Parent-Task: JAVASERVERFACES_SPEC_PUBLIC-1090

@glassfishrobot
Copy link
Author

Issue-Links:
depends on
JAVASERVERFACES-2513

@glassfishrobot
Copy link
Author

File: 20120706-1842-i_spec_1111.patch
Attached By: @edburns

@glassfishrobot
Copy link
Author

File: 20120706-2248-i_spec_1111.patch
Attached By: @edburns

@glassfishrobot
Copy link
Author

File: 20120706-2248-i_spec_1111.zip
Attached By: @edburns

@glassfishrobot
Copy link
Author

File: 20120709-1625-i_spec_1111.patch
Attached By: @edburns

@glassfishrobot
Copy link
Author

File: 20120709-1625-i_spec_1111.zip
Attached By: @edburns

@glassfishrobot
Copy link
Author

File: 20120710-0105-i_spec_1111.patch
Attached By: @edburns

@glassfishrobot
Copy link
Author

File: 20120710-0105-i_spec_1111.zip
Attached By: @edburns

@glassfishrobot
Copy link
Author

File: 20120710-1123-i_spec_1111.patch
Attached By: @edburns

@glassfishrobot
Copy link
Author

File: 20120710-1123-i_spec_1111.zip
Attached By: @edburns

@glassfishrobot
Copy link
Author

@edburns said:
Snapshot. Was about to commit but now I see the test failure Manfred found when enabling matrix testing for these matrices:

++++++++++++++++++++SECTION: -Dwebapp.projectStage=Production -Dwebapp.stateSavingMethod=client -Dwebapp.partialStateSaving=false

Tests run: 3, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 1.507 sec <<< FAILURE!

++++++++++++++++++++SECTION: -Dwebapp.projectStage=Development -Dwebapp.stateSavingMethod=client -Dwebapp.partialStateSaving=false

Tests run: 3, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 1.507 sec <<< FAILURE!

I wasn't seeing them before because my script was not correctly passing the matrix test parameters to the test harness.

Now, I really have to fix this!

@glassfishrobot
Copy link
Author

File: 20120710-1853-i_spec_1111.patch
Attached By: @edburns

@glassfishrobot
Copy link
Author

File: 20120710-1853-i_spec_1111.zip
Attached By: @edburns

@glassfishrobot
Copy link
Author

File: 20120913-1810-i_spec_1111.patch
Attached By: @edburns

@glassfishrobot
Copy link
Author

@edburns said:
Ready for PRD

@glassfishrobot
Copy link
Author

@edburns said:
After discussing with Frank today, I need some more work on button renderer.

@glassfishrobot
Copy link
Author

Marked as fixed on Thursday, January 31st 2013, 10:28:47 pm

@glassfishrobot
Copy link
Author

@edburns said:
M jsf-ri/src/main/java/com/sun/faces/facelets/tag/composite/BehaviorHolderWrapper.java

  • Remove getPassThroughAttributes(), it's available on the parent. Andy
    was it safe to do this? I think so, but I could use your oversight.

M jsf-api/src/main/java/javax/faces/component/UIComponent.java
M jsf-api/src/main/java/javax/faces/component/UIComponentBase.java

  • Per Andy Schwartz's recommendation, remove
    UIComponentBase.getPassThroughAttributes(), moving it to the
    superclass and making it final.
    Sending jsf-api/src/main/java/javax/faces/component/UIComponent.java
    Sending jsf-api/src/main/java/javax/faces/component/UIComponentBase.java
    Sending jsf-ri/src/main/java/com/sun/faces/facelets/tag/composite/BehaviorHolderWrapper.java
    Transmitting file data ...
    Committed revision 11667.

@glassfishrobot
Copy link
Author

This issue was imported from java.net JIRA JAVASERVERFACES_SPEC_PUBLIC-1111

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants