Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calendar-specific settings layout broken on iPad #102

Open
2 of 7 tasks
kristofferpeterhansel opened this issue Mar 1, 2024 · 9 comments · Fixed by #109
Open
2 of 7 tasks

Calendar-specific settings layout broken on iPad #102

kristofferpeterhansel opened this issue Mar 1, 2024 · 9 comments · Fixed by #109

Comments

@kristofferpeterhansel
Copy link

Check for existing bug reports before submitting.

  • I searched for existing Bug Reports and found no similar reports.

Expected Behavior

When opening the settings for a given calendar. It should be possible to navigate to the various sub-pages though the left-hand tabs.

Current behaviour

The entire left-side tab-selector is gone.

Screenshot 2024-03-01 at 18 23 05

Reproduction

This seems to be 100% consistent. Simply go to modify any calendar though one of the two buttons (star or wrench - not really sure what whey they are both there BTW).

Settings for the calendar will open. But the left-hand pane is not there.

Which Operating Systems are you using?

  • Android
  • iPhone/iPad
  • Linux
  • macOS
  • Windows

Obsidian Version Check

1.5.8(126)

Plugin Version

1.0.5

Confirmation

  • I have disabled all other plugins and the issue still persists.

Possible solution

No response

@ebullient
Copy link
Contributor

The star is for folks like me that just use a preset with no chance of accidentally changing it. It should show fewer settings.

Settings are now shown in a new pop-over modal. Clicking anywhere outside of the modal will close it.

There is a new sidebar for the popover modal that is not rendering on iOS.

@kristofferpeterhansel
Copy link
Author

kristofferpeterhansel commented Mar 3, 2024

The star is for folks like me that just use a preset with no chance of accidentally changing it. It should show fewer settings.

Okay. I twas a bit of an offhand comment just to point it out is a bit of a confusing UX. Maybe just have one button and enable more detailed editing on the general pane or something? 🤷

@ebullient
Copy link
Contributor

There should be a left nav on that popover modal, and that is missing. So you're right.

I was just letting you know what the sparkle buttons are for (and there are some UX changes coming for that, too).

@kristofferpeterhansel
Copy link
Author

Looks like this works for the "Custom Creator" button (although I didn't try it before. But the change looks like it would make a difference). But not when editing existing calendars.

@valentine195
Copy link
Member

Hmm, really? It uses the same thing. How odd

@valentine195 valentine195 reopened this Mar 11, 2024
@kristofferpeterhansel
Copy link
Author

kristofferpeterhansel commented Mar 11, 2024

Hmm, really? It uses the same thing. How odd

Yeah. I made sure it was 1.0.10. Reloaded it manually. Even force quit the app too. And still I don't see the left-hand tabs

@kristofferpeterhansel
Copy link
Author

I am going to have to correct myself here. It works in the full editor (pencil icon?) but not the reduced editor (star icon).

Sorry. I thought I had checked both but I must not have.

@valentine195
Copy link
Member

@kristofferpeterhansel is this still an issue

@kristofferpeterhansel
Copy link
Author

kristofferpeterhansel commented Apr 9, 2024

Yes. Still happens.

iPad.Issue.mov

Here I fist tap the quick creator. Close it and then the custom creator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants