Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any expression using parentheses breaks #58

Closed
mulfok opened this issue Nov 23, 2021 · 2 comments
Closed

Any expression using parentheses breaks #58

mulfok opened this issue Nov 23, 2021 · 2 comments

Comments

@mulfok
Copy link

mulfok commented Nov 23, 2021

As of 7.8.3, it looks like any dice rolls with parenthesis have stopped working.

Dice usage such as: dice: 1 + (overall_level - 3)d5 used to produce:

demonstration

...it now unfortunately doesn't render anything, and opening any note with expressions like these produce the error message:

There was an error parsing the dice string: dice: 1 + (overall_level - 3)d5

Error: Mismatched Parentheses

image

I've tried rearranging the parentheses in every-which-way, but on both my phone and computer, they return the same error message.

This might just be some sillyness on my part, but both the brackets are the same.
Sorry for the trouble haha,,

@valentine195
Copy link
Member

No worries!

I am actually surprised that this ever worked, and if it did. it likely did not work the way you thought it was working behind the scenes.

I'm not entirely sure I'll be able to implement this, unfortunately, because the entire string is parsed for tokens and then the stack is parsed. Let me give it some though.

@sigrunixia
Copy link
Member

Much of this functionality was implemented in different ways, through conditionals and text strings. If something more is needed, a new issue can be created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants