Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limited Composite PK support #402

Merged
merged 5 commits into from Jun 16, 2015
Merged

Conversation

comtel2000
Copy link
Contributor

@comtel2000
Copy link
Contributor Author

Please skip the first jdk6 commit. I got strange issues in my eclipse IDE with the default jdk5 setup.

ipolevoy pushed a commit that referenced this pull request Jun 16, 2015
Limited Composite PK support
@ipolevoy ipolevoy merged commit 6783250 into javalite:master Jun 16, 2015
@ipolevoy
Copy link
Member

@comtel2000 , I added and cleaned your code: #405.
Also, added docs here: http://javalite.io/surrogate_primary_keys#what-about-composite-pks
it is part of the framework now, thanks for your contribution!

@swolf91
Copy link

swolf91 commented Apr 4, 2016

@ipolevoy Did you plan to add relationship support in the near future? At least it would be great to have a working include method, so that entries can be cached.
Is there more work to do as changing the orderBy properties?

@ipolevoy
Copy link
Member

ipolevoy commented Apr 4, 2016

@boeserwolf91 , currently no plans to add relationships for composite keys. The ActiveRecord too does not support composite keys out of the box (available as a separate gem outside Rails project). If we get enough requests for this, we might consider.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants