Issue 1658 Make JP buildable on Java 10 - Implementing review comments

javaparser · Jun 30, 2018 · d77c144 · d77c144
1 parent a82e27c
commit d77c144
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/.travis.yml b/.travis.yml
@@ -5,6 +5,7 @@ script: mvn test -P AlsoSlowTests
 jdk:
   - oraclejdk8
   - oraclejdk9
+  - oraclejdk10
 notifications:
   webhooks:
     urls:

diff --git a/...-symbol-solver-testing/src/test/java/com/github/javaparser/symbolsolver/AbstractTest.java b/...-symbol-solver-testing/src/test/java/com/github/javaparser/symbolsolver/AbstractTest.java
@@ -49,9 +49,9 @@ protected boolean isJava10() {
         return System.getProperty("java.version").startsWith("10.");
     }
 
-    protected boolean isJavaVersionAbove9() {
+    protected boolean isJavaVersion9OrAbove() {
         String jdkVersion = System.getProperty("java.version");
-        return Integer.parseInt(jdkVersion.substring(0,jdkVersion.indexOf('.'))) >= 9;
+        return Integer.parseInt(jdkVersion.substring(0, jdkVersion.indexOf('.'))) >= 9;
     }
 
     protected boolean isJava8() {

diff --git a/...va/com/github/javaparser/symbolsolver/reflectionmodel/ReflectionClassDeclarationTest.java b/...va/com/github/javaparser/symbolsolver/reflectionmodel/ReflectionClassDeclarationTest.java
@@ -173,7 +173,7 @@ public void testGetDeclaredMethods() {
                 .filter(m -> m.accessSpecifier() != AccessSpecifier.PRIVATE && m.accessSpecifier() != AccessSpecifier.DEFAULT)
                 .sorted((a, b) -> a.getName().compareTo(b.getName()))
                 .collect(Collectors.toList());
-        if (isJavaVersionAbove9()) {
+        if (isJavaVersion9OrAbove()) {
             assertEquals(69, methods.size());
         } else {
             assertEquals(67, methods.size());
@@ -182,7 +182,7 @@ public void testGetDeclaredMethods() {
         assertEquals(false, methods.get(0).isAbstract());
         assertEquals(1, methods.get(0).getNumberOfParams());
         assertEquals("int", methods.get(0).getParam(0).getType().describe());
-        if (isJavaVersionAbove9()) {
+        if (isJavaVersion9OrAbove()) {
             assertEquals("compareTo", methods.get(6).getName());
             assertEquals(false, methods.get(6).isAbstract());
             assertEquals(1, methods.get(6).getNumberOfParams());