Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a clone method #147

Closed
ftomassetti opened this issue Jun 8, 2015 · 2 comments
Closed

Add a clone method #147

ftomassetti opened this issue Jun 8, 2015 · 2 comments
Assignees
@ftomassetti
Labels
Improvement Not a bug, but a way that JP can be be enhanced to work better.
Milestone
2.4.0

Comments

@ftomassetti
Copy link
Member

Reading this question (http://stackoverflow.com/questions/30633535/copy-nodes-in-ast) it seems that it is not obvious how to clone methods. I think we could easily add a clone method wrapping the CloneVisitor.
What do you think?
@ptitjes
Copy link
Contributor

ptitjes commented Jun 8, 2015

It makes sense. In addition to implement Object.clone(), Node could even implement the Cloneable interface. +1 for me.

@ftomassetti ftomassetti self-assigned this Jun 8, 2015
@ptitjes ptitjes added the Improvement Not a bug, but a way that JP can be be enhanced to work better. label Jun 27, 2015
@ptitjes ptitjes added this to the 3.0 milestone Jun 27, 2015
@ftomassetti ftomassetti mentioned this issue Jul 13, 2015
Merged
@ftomassetti
Copy link
Member Author

This has been done in #161

@matozoid matozoid modified the milestones: 2.4.0, 3.0 Apr 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ftomassetti ftomassetti

Labels
Improvement Not a bug, but a way that JP can be be enhanced to work better.
Projects
None yet
Milestone
2.4.0
Development

No branches or pull requests
3 participants
@matozoid @ptitjes @ftomassetti