Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add plotting module back to Nodejs version #297

Closed
risenW opened this issue Oct 14, 2021 · 4 comments · Fixed by #319
Closed

Add plotting module back to Nodejs version #297

risenW opened this issue Oct 14, 2021 · 4 comments · Fixed by #319
Assignees
@risenW
Labels
enhancement New feature or request

Comments

@risenW
Copy link
Member

risenW commented Oct 14, 2021 •
edited

In order to support interactive plotting in the Nodejs Jupyter notebook, we need to add the plotting module and its types back to the danfojs-node lib. See discussion here.
@risenW risenW added the enhancement New feature or request label Oct 14, 2021
@risenW risenW self-assigned this Oct 14, 2021
@DonJayamanne
Copy link

@risenW DId you want me to submit a PR for this?

@risenW
Copy link
Member Author

risenW commented Nov 9, 2021

@risenW DId you want me to submit a PR for this?

@DonJayamanne if you have the time, please do.

@risenW risenW mentioned this issue Dec 5, 2021
Merged
@risenW risenW mentioned this issue Dec 5, 2021
Merged
@DonJayamanne
Copy link

Thanks, sorry I didn't get to this, been very busy with an upcoming relocation...

@risenW
Copy link
Member Author

risenW commented Dec 6, 2021

Thanks, sorry I didn't get to this, been very busy with an upcoming relocation...

@DonJayamanne No worries, I fixed this already, and pushed to the latest version v0.3.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@risenW risenW

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Re-add plotly module to node version javascriptdata/danfojs
2 participants
@DonJayamanne @risenW