Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataFrame groupby typings does not follow groupby implementation #315

Closed
Devwulf opened this issue Nov 23, 2021 · 2 comments
Closed

DataFrame groupby typings does not follow groupby implementation #315

Devwulf opened this issue Nov 23, 2021 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@Devwulf
Copy link
Contributor

Devwulf commented Nov 23, 2021

Hello! I've noticed that the groupby() typings for dataframes do not follow the intended implementation of the groupby() function.

The documentation here:
https://github.com/opensource9ja/danfojs/blob/146ba82ca723527f5c2008b5077c6a13d196e01f/danfojs-browser/src/core/frame.js#L2310
states that the col parameter is a list of (string) columns, while the typing here:
https://github.com/opensource9ja/danfojs/blob/146ba82ca723527f5c2008b5077c6a13d196e01f/danfojs-browser/types/core/frame.d.ts#L554
declares that the function only takes in a string value. This will probably lead to errors when used, since string values are not mappable.

Also, perhaps this parameter can be made optional by allowing it to be undefined?

@risenW
Copy link
Member

risenW commented Nov 28, 2021

Thanks for raising this. @steveoni Can you update this

@risenW risenW added the bug Something isn't working label Nov 28, 2021
@risenW
Copy link
Member

risenW commented Dec 5, 2021

Fixed!

@risenW risenW closed this as completed Dec 5, 2021
@risenW risenW mentioned this issue Dec 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants