Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: a couple of ideas #1

Merged
merged 1 commit into from Aug 31, 2021
Merged

feat: a couple of ideas #1

merged 1 commit into from Aug 31, 2021

Conversation

peterpeterparker
Copy link
Contributor

@peterpeterparker peterpeterparker commented Aug 30, 2021

Hi Jorge,

I had a quick look at the "party service" and here's a couple of spontaneous ideas :

  • createParty and deleteParty had no return types specified
  • promise of navigateByUrl was not handled
  • in party.page.ts I would init the observable variable only once so that you don't init a stream (even if empty) without closing it before assigning it again to the effective stream which should be displayed
  • in getPartyList and getPartyDetail just a quick draft to leverage rxjs
  • I also quickly added prettier and only formatted the code I modified (might run a npx prettier --write . afterwards if you think it's a good idea)

Hope it helps, cool repo! Starred ⭐️

P.S.: Note I did not test my code at all, therefore good possible it does not work. This PR has no other goal than sharing some spontaneous ideas.

@javebratt javebratt merged commit 4e51a41 into javebratt:main Aug 31, 2021
@peterpeterparker peterpeterparker deleted the feat/couple-of-ideas branch August 31, 2021 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants