Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Jorge,
I had a quick look at the "party service" and here's a couple of spontaneous ideas :
createParty
anddeleteParty
had no return types specifiednavigateByUrl
was not handledparty.page.ts
I would init the observable variable only once so that you don't init a stream (even if empty) without closing it before assigning it again to the effective stream which should be displayedgetPartyList
andgetPartyDetail
just a quick draft to leverage rxjsnpx prettier --write .
afterwards if you think it's a good idea)Hope it helps, cool repo! Starred ⭐️
P.S.: Note I did not test my code at all, therefore good possible it does not work. This PR has no other goal than sharing some spontaneous ideas.