Detect process id reuse #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Process IDs (PIDs) are reused on Linux, so it's possible that we start profiling a Ruby process with some PID and later on, while still profiling, this process exits and a new one is spawned with this same PID. The profiling information will be wrong. rbperf has some guardrails to help here, such as ensuring that method and path names are valid unicode, otherwise we consider the stack to be invalid, but it would be best to actively ensure we don't have a race condition here. By using the `pid + start_time` of the process, we should be able to have a truly unique identifier of every process Signed-off-by: Francisco Javier Honduvilla Coto <javierhonduco@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Process IDs (PIDs) are reused on Linux, so it's possible that we start profiling
a Ruby process with some PID and later on, while still profiling, this
process exits and a new one is spawned with this same PID.
The profiling information will be wrong. rbperf has some guardrails to
help here, such as ensuring that method and path names are valid
unicode, otherwise we consider the stack to be invalid, but it would be
best to actively ensure we don't have a race condition here.
By using the
pid + start_timeof the process, we should be able to havea truly unique identifier of every process
Signed-off-by: Francisco Javier Honduvilla Coto javierhonduco@gmail.com