Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deterministic schema generation #76

Closed
bsander opened this issue Mar 3, 2021 · 3 comments
Closed

Deterministic schema generation #76

bsander opened this issue Mar 3, 2021 · 3 comments

Comments

@bsander
Copy link

bsander commented Mar 3, 2021

Hi! Thanks for the great library, we love it on our project! One thing I've noticed is that sometimes during development after I drop and recreate a database, the schema changes slightly, putting some union types (most notably the type UniqueIndex) into a different order. This generates unnecessary noise, so it would be great if these union types could be generated deterministically (for example alphabetically sorted).

Example:

Screen Shot 2021-03-03 at 11 28 30

@jawj
Copy link
Owner

jawj commented Mar 3, 2021

Ah, good catch, that's not supposed to happen. I'll make sure that gets sorted.

@jawj
Copy link
Owner

jawj commented Mar 4, 2021

OK, this should be fixed in 3.5. I did not spot any types other than UniqueIndex that were affected — please let me know if you encounter any.

@jawj jawj closed this as completed Mar 4, 2021
@bsander
Copy link
Author

bsander commented Mar 4, 2021

Thanks so much for the fast action! I'll be sure to keep an eye out for any similar occurrences.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants