Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BD Documentation Clarification, and suggestions #177

Open
moyuanchen opened this issue Feb 8, 2022 · 3 comments
Open

BD Documentation Clarification, and suggestions #177

moyuanchen opened this issue Feb 8, 2022 · 3 comments

Comments

@moyuanchen
Copy link

  1. The gamma in the Brownian dynamics is not clearly defined, there should be equations specifying the gamma is 6pi eta R/m, not 6 pi eta R
  2. The Mass property in the brownianState object is not used in the calculation and the simulation can be made marginally more efficient if we don’t save the mass properties
  3. In the dynamics calculation mass is not used, if instead, we pass in the radius information of the particles (and the dynamic viscosity) we can accommodate simulations with particles of different sizes and different frictions.
@sschoenholz sschoenholz reopened this Feb 9, 2022
@sschoenholz
Copy link
Collaborator

Hey! Just reopened this issue so that I can track these great suggestions and hopefully get to them. Thanks for reporting.

@sschoenholz
Copy link
Collaborator

If you would be up for it, I would also be happy to accept a PR improving the BD simulations.

@moyuanchen
Copy link
Author

Hi Sam,

Thank you for the response! I would be happy to write some code and see what I can do! I will make a pull request after I have tested my code.

Please let me know if there is anything I should keep in mind when writing the code.

Best,

Moyuan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants