Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mod Compat] Minegate #23

Closed
MissGamerz opened this issue May 17, 2021 · 4 comments
Closed

[Mod Compat] Minegate #23

MissGamerz opened this issue May 17, 2021 · 4 comments
Assignees
Labels
incompatibility There is a bug that causes incompatibility with other mods.

Comments

@MissGamerz
Copy link

i see youve added atbw but minegate anther mod which has waaay more stuff and covers the same functionality is not compatible with your mod, however they include tags in their mod "minecraft:sticks" to give compat to other mods

could you please add this???

@JayCeeCreates JayCeeCreates self-assigned this May 18, 2021
@JayCeeCreates JayCeeCreates added the incompatibility There is a bug that causes incompatibility with other mods. label May 18, 2021
@JayCeeCreates
Copy link
Owner

Yo, thanks for your input!

I've looked into the code for Minegate, and it seems like it's both this and that mod's issue.

  • On my hand, I have to change the tool recipes to use a common stick tag for better compatibility with other mods.
  • On the other hand, Minegate (and other possible mods that add stick variants) has to make a common tag for sticks.

I'll try to get in touch with the other party.

@JayCeeCreates
Copy link
Owner

Extra note: it also seems like the other party has the code in open source, but has the license of "All Rights Reserved" 🤔

@MissGamerz
Copy link
Author

MissGamerz commented May 18, 2021

if everyone used minecraft:sticks

that would be nice as it would make sense

so this would be more to get atbyw to use the same thing as minegate to get this stuff compatible as using a common dir as the data pack such as minecraft will help modpacks such as ours so we can overwrite them easily due to the way fabric loads mod datapacks vs minecraft

we use datapacks to refine stuff in our packs which has been an adventure because of fabric using datapack and overwriting vanilla behaviour so this is how im discovering all this with mods tags as the only way you can get these tags is by open the jar with a archive program and check the datapack it includes oorr github, 9/10 they dont document it its been annoying

@MissGamerz MissGamerz changed the title mod compat (minegate) [Mod Compat] Minegate Jul 2, 2021
@JayCeeCreates
Copy link
Owner

MineGate dev merged my PR regarding sticks, so I consider this issue closed-

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
incompatibility There is a bug that causes incompatibility with other mods.
Projects
None yet
Development

No branches or pull requests

2 participants