Network error: Cannot read property 'headers' of undefined

[bensalilijames]

On upgrading from 3.0.3 to 4.0.0 I get the following error:

Network error: Cannot read property 'headers' of undefined
  at new ApolloError ([...]/node_modules/apollo-client/apollo.umd.js:1851:28)

I think it should be passing options through to window.fetch as well as opts?

[jaydenseric]

@AdamYee ?

Just tried updating apollo-upload-examples to v4 and it immediately errors.

[jaydenseric]

I think this and this should not have been changed.

[AdamYee]

Hey guys,

I was able to reproduce by removing opts from the createNetworkInterface config. Something that I didn't test because my app needs the cookies. Fetch queries (not mutations) will just fail silently, but when I attempt to upload a file I get the same error as @benhjames.

@jaydenseric so the changes to the lines you referenced are still needed, but they need to pass in an empty object when there isn't an opts defined when creating the network interface like what most people probably do at first:

const networkInterface = createNetworkInterface({
  uri: '/graphql'
});

The fix should look something like this in the network-interface.js and batch-network-interface.js files:

return _HTTPFetchNetworkInte.prototype.fetchFromRemoteEndpoint.call(this, { request: request, options: options.opts || {} });

In the meantime, if people need a quick workaround they can create the network interface with an empty opts:

const networkInterface = createNetworkInterface({
  uri: '/graphql',
  opts: {} // just to get around the 4.0.0 bug
});

😃

[jaydenseric]

This seems to be ok now on master branch.

I am getting paranoid every time I publish a new release, it's so hard to manually test everything. We really need some unit tests!

[jaydenseric]

Just released v4.0.1, please let me know if everything is happy chappy 🙏

[AdamYee]

@jaydenseric updated to 4.0.1 and all is well.

[bensalilijames]

Yep, thanks a lot!