Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package rename #68

Closed
5 tasks done
jaydenseric opened this issue Apr 11, 2018 · 4 comments
Closed
5 tasks done

Package rename #68

jaydenseric opened this issue Apr 11, 2018 · 4 comments

Comments

@jaydenseric
Copy link
Owner

jaydenseric commented Apr 11, 2018

It is time to drop apollo from the apollo-upload-server package name as this package is also useful for non-Apollo GraphQL servers and clients.

Anyone have any tips for renaming a package? I have never done it before and it seems like an inherently disruptive thing to do.

I'm thinking:

  • Research and achieve compatibility with other Node.js GraphQL servers, i.e. express-graphql.
  • Rename this repo in GitHub. GitHub automatically redirects people visiting old URLs.
  • Rename the package in package.json and anywhere else the name appears.
  • Publish the the new package.
  • Deprecate the old package, advising to switch to the new package.

I'll think about it for a bit before doing it 😅

@jaydenseric
Copy link
Owner Author

I've found this package to be compatible with:

@giautm
Copy link

giautm commented Jun 26, 2018

graphql-upload-server <-- This is available npm package name, you could use it. 😄

@jaydenseric
Copy link
Owner Author

jaydenseric commented Sep 18, 2018

All done 🎉

I just published graphql-upload, you can see the changelog entry for a migration guide.

Here is the deprecation warning everyone sees when attempting to install apollo-upload-server:

screen shot 2018-09-18 at 3 27 21 pm

The Github short URL links to this issue.

jaydenseric added a commit to jaydenseric/graphql-multipart-request-spec that referenced this issue Sep 18, 2018
@jaydenseric
Copy link
Owner Author

Really happy with the change, it looks so clean and logical everywhere now 😍

screen shot 2018-09-18 at 4 07 25 pm

screen shot 2018-09-18 at 4 06 33 pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants