Added back, but deprecated, the file upload stream property.
#107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mike-marcacci is this the right thing to do, and how should it be documented? I think maybe don't document |
mike-marcacci
approved these changes
Aug 17, 2018
matijagaspar
added a commit
to matijagaspar/apollo-upload-client
that referenced
this pull request
Sep 20, 2018
…eprecation: jaydenseric/graphql-upload#107 - Added @babel/polyfill to dev dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accessing an
Uploadscalar promise resolvedstreamproperty results in a deprecation warning that recommends usingcreateReadStreaminstead. It will be removed in a future release.A
streamgetter creates the stream usingcreateReadStreamthe first time it is accessed, then reuses the stream following times. It also serves the deprecation warning.