Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break each pout function into a supporting class #36

Closed
Jaymon opened this issue Dec 22, 2018 · 0 comments
Closed

Break each pout function into a supporting class #36

Jaymon opened this issue Dec 22, 2018 · 0 comments

Comments

@Jaymon
Copy link
Owner

Jaymon commented Dec 22, 2018

Now that all the actual string outputting code of all the values (see #32) has been broken out into specific supporting classes, and all the calling and parsing has also been broken out into their own classes it would be great to have like a V class that would be the backend for pout.v() and a T class that would handle pout.t() etc.

This would make it easier to override and customize functionality and keep everything contained to what applies to it instead of the previous solution of a monolithic Pout class.

Jaymon added a commit that referenced this issue Dec 27, 2018
…ace commit as discussed in issue #36. I think this also addresses #31, which I was having problems fixing because my fix was not only 3x slower but broke the previous extending capability. I think this addresses both those issues now and the code is much cleaner. Tests are not passing yet and the code needs to be cleaned up since there is a lot of dead and commented out code and tests.
@Jaymon Jaymon closed this as completed in aa8f34d Dec 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant