localized command should validate input file before running

[qtehfw]

When I ran it today it ran into the above issue, but it had already started modifying the strings.xml files so ./app/src/main/res/values-ko/strings.xml ended up in an invalid state:

[qtehfw]

It could also search for unescaped apostrophes, and potentially escape them, before generating the outputs.

[jayrave]

Can you paste the line that led to this issue? The one from the CSV file

[qtehfw]

모델"%1$s"에 오류가 있습니다. 재업로드를 위해서는 <![DATA[<a href="https://app.fieldwire.com">app.fieldwire.com]]>에서 온라인에 접속하여 다시 시도해 주세요

[qtehfw]

I just had to add a 'C' to the <![DATA and re-run the command

[jayrave]

Looks like even localize would fail if the default strings file has a string like this. I guess for this we can ask localize to perform validate before it starts its own run.

For localized, it could take some more work since essentially we want to validate the CSV before the XML files are updated. May be we read in all the CSV strings, run validations in memory & proceed with XML updates only if all of them succeed?

[qtehfw]

Yeah, but I think in this case it was probably due to a typo in the translated string.

For validate, is the XML parsed into some kind of in-memory data structure before validating? If yes, does localized parse the csv into that same data structure?

[jayrave]

Sorry, was a bit busy with work!

Yes. We parse into AndroidString & then perform the validations. Localized also deals with strings in this format. We should be able to reuse stuff here.

Another idea: I guess these failures happen if the XML is mis-formatted like <![DATA instead of <![CDATA. To makes things easy for us, before localize & localized (may be even validate), we can just validate if strings are valid XML values