Add parameter to lifecycleParticipant #445
Conversation
|
Oh and I only quickly tested it to see if the param were taken into account (they were) but didn't do an actual test by building till the end a project & running it. I couldn't help myself to implement it directly as tomorrow I won't be able to. So if @william-ferguson-au wanna test this it would be perfect. |
| @@ -151,6 +176,28 @@ else if ( type.equals( AndroidExtension.APKLIB ) && includeLibsJarsForApklib ) | |||
| log.debug( "ClasspathModifierLifecycleParticipant#afterProjectsRead - finish" ); | |||
| } | |||
|
|
|||
| protected String getPluginId() | |||
| { | |||
| return "android-maven-plugin"; | |||
There was a problem hiding this comment.
Should this be a generic constant. Maybe even filtered into a properties file from the pom? Imho at least a static constant in some plugin wide class.
There was a problem hiding this comment.
Okay, I did it fast so I could sleep 😁
I'll change that soon.
On 4 Sep 2014 23:47, "William Ferguson" notifications@github.com wrote:
In
src/main/java/com/jayway/maven/plugins/android/phase_prebuild/ClasspathModifierLifecycleParticipant.java:@@ -151,6 +176,28 @@ else if ( type.equals( AndroidExtension.APKLIB ) && includeLibsJarsForApklib )
log.debug( "ClasspathModifierLifecycleParticipant#afterProjectsRead - finish" );
}
- protected String getPluginId()
- {
return "android-maven-plugin";Agree
—
Reply to this email directly or view it on GitHub
https://github.com/jayway/maven-android-plugin/pull/445/files#r17144689.
There was a problem hiding this comment.
Where do you want to put that constant?
I don't think you should put it in the pom or in a property file...
|
Better? Btw I couldn't find any other place where we would need to use this new class but maybe I searched for the wrong things. |
Shusshu
force-pushed
the
param-participant
branch
from
23ebdd6
to
0ca466b
Compare
| <configuration> | ||
| <signature> | ||
| <groupId>org.codehaus.mojo.signature</groupId> | ||
| <artifactId>java16</artifactId> |
There was a problem hiding this comment.
I pulled master first and then rebased & squashed.
Now I know if I want to rebase & squash I should not pull master. sorry for that
There was a problem hiding this comment.
That is from the pull request that I submitted this morning, that Manfred
has already merged.
On Tue, Sep 9, 2014 at 6:08 PM, Benoit Billington notifications@github.com
wrote:
In pom.xml:
@@ -694,6 +694,27 @@
26a4c760b261ca
+
<plugin><groupId>org.codehaus.mojo</groupId><artifactId>animal-sniffer-maven-plugin</artifactId><configuration><signature><groupId>org.codehaus.mojo.signature</groupId><artifactId>java16</artifactId>I pulled master first and then rebased & squashed dunno why it added
this.....—
Reply to this email directly or view it on GitHub
https://github.com/jayway/maven-android-plugin/pull/445/files#r17287091.
There was a problem hiding this comment.
Yes I know I should not pull from master when I rebase & squash
|
ready to merge |
|
I had something a bit different in mind. I will try to pull this in and refactor .. hopefully tonight. |
Add parameter to lifecycleParticipant
|
Done and in master now. |
Following on #422
It adds the ability to use parameters in the pom to customize the way the lifecycleParticipant deals with dependencies in the libs folder of the apklib/aar
This is now complete.