Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Greatly improve responsiveness of the virtual keyboard on the website #123

Merged
merged 1 commit into from Jan 11, 2020
Merged

Greatly improve responsiveness of the virtual keyboard on the website #123

merged 1 commit into from Jan 11, 2020

Conversation

vitormv
Copy link
Contributor

@vitormv vitormv commented Jan 11, 2020

Hi, I added some small changes to the CSS of the virtual keyboard, because:

  • The current keyboard only fully changes the color to blue if the user presses the key long enough.
  • Very quick key presses barely show on the keyboard. Also same happens if you are typing a sentence and normal typing speed, the keyboard barely lits up.
  • Currently the keyboard color fades very quickly, if user types while looking at his own keyboard, by the time he/she looks up the screen, color already changed again.

So, since the keyboard is above the fold on the website and therefore the first thing users will play around with, I improved its responsivess by:

  • Make the color transition when the key is lighing up extremly fast 1ms, so even extremely quick key presses will be lit up. Try for yourself!
  • Slightly increase the fade-out transition, and add a easing method.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 210

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 81.364%

Totals Coverage Status
Change from base Build 208: 0.0%
Covered Lines: 193
Relevant Lines: 207

💛 - Coveralls

@codecov-io
Copy link

codecov-io commented Jan 11, 2020

Codecov Report

Merging #123 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #123   +/-   ##
=======================================
  Coverage   93.23%   93.23%           
=======================================
  Files           1        1           
  Lines         207      207           
=======================================
  Hits          193      193           
  Misses         14       14
Impacted Files Coverage Δ
dist/hotkeys.js 93.23% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f362846...c8a19a5. Read the comment docs.

@jaywcjlove jaywcjlove merged commit c6634a8 into jaywcjlove:master Jan 11, 2020
@vitormv vitormv deleted the improve-virtual-keyboard-resposiveness branch January 11, 2020 18:29
@jaywcjlove
Copy link
Owner

@vitormv nice! 👍

thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants