Add user profile at authentication #447

christophehenry · 2018-02-27T07:44:17Z

/api-token-auth/ now returns limited profile infos in addition to token:

{
  "guid": "eba9d938-71a2-4570-96c2-99e6e6bb232f",
  "handle": "karl_marx@127.0.0.1:8000",
  "home_url": "http:\/\/127.0.0.1:8000\/p\/eba9d938-71a2-4570-96c2-99e6e6bb232f\/",
  "id": 2,
  "image_url_small": "http:\/\/127.0.0.1:8000\/static\/images\/pony50.png",
  "is_local": true,
  "name": "",
  "url": "http:\/\/127.0.0.1:8000\/p\/eba9d938-71a2-4570-96c2-99e6e6bb232f\/",
  "token": "0ab231f9f7ab63a6f78fd9746b9bdc9926a734fd"
}

Tests
Update the docs to explain how to recover token

Refs: #446

codecov · 2018-02-27T07:52:22Z

Codecov Report

Merging #447 into master will increase coverage by 0.03%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #447      +/-   ##
==========================================
+ Coverage   92.43%   92.47%   +0.03%     
==========================================
  Files         107      107              
  Lines        3516     3533      +17     
==========================================
+ Hits         3250     3267      +17     
  Misses        266      266

Impacted Files	Coverage Δ
config/urls.py	`80% <100%> (-0.65%)`	⬇️
socialhome/views.py	`100% <100%> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f872152...b8dad13. Read the comment docs.

jaywink

Great! <3 Just needs a test since we're now owning the code from DRF and thus responsible for testing the view post doesn't crash and burn.

jaywink · 2018-02-27T22:16:43Z

Oh yeah, the docs should also have a little update where they currently say how to retrieve the token to indicate it now returns also some profile info.

christophehenry · 2018-02-28T09:09:02Z

Right. Added to the tasks.

christophehenry · 2018-03-01T10:56:15Z

@jaywink I have a problem with this test. What's the way to create the user in DB so that Django REST API is aware of it?

Also, how can I write the Swagger documentation for this endpoint?

jaywink · 2018-03-02T23:18:22Z

socialhome/tests/test_viewsets.py

+        self.assertEqual(response.data, {'non_field_errors': ['Unable to log in with provided credentials.']})
+
+    def test_authentication(self):
+        self.client.force_authenticate(self.user, token="0ab231f9f7ab63a6f78fd9746b9bdc9926a734fd")


You're testing login so you shouldn't be forcing authentication in the test - this line shouldn't be here imho.

jaywink · 2018-03-02T23:20:10Z

socialhome/tests/test_viewsets.py

+
+    def test_authentication(self):
+        self.client.force_authenticate(self.user, token="0ab231f9f7ab63a6f78fd9746b9bdc9926a734fd")
+        response = self.client.post(reverse("api-token-auth"),


Since this is a SocialhomeAPITestCase you don't need to use self.client. Our test classes use some handy helper stuff which means you can just do self.post("api-token-auth", {"username": self.user.username, "password": self.user.password}). (see here)

Does that work? If not I'm not sure what could be the problem. The password should be set by the factory so that shouldn't be an issue..

jaywink · 2018-03-02T23:25:11Z

Also, how can I write the Swagger documentation for this endpoint?

I mean this page - but Swagger docs would be nice as well! They're done by adding a docstring to the view itself. See this page. So basically, some generic title and a post: section should do it.

christophehenry · 2018-03-03T11:56:12Z

Done. Ready for review.

jaywink

A few minor comments, then good to go!

jaywink · 2018-03-03T17:49:58Z

docs/changelog.rst

@@ -443,6 +443,7 @@ Changed

 * Create and update content will now redirect to the content created or updated. Previous behaviour was user preferred landing page.
 * Delete content will now redirect back to the page where the delete was triggered from. Previous behaviour was user preferred landing page. If the content delete is triggered from the content detail page, redirect will happen to user preferred landing page as before. (`#204 <https://github.com/jaywink/socialhome/issues/204>`_)
+* ``/api-token-auth/`` endpoint now returns limited profile information in addition to token


Changelog entry is in the wrong place, it should be in the latest upcoming release (top of file) not first release (bottom of file).

jaywink · 2018-03-03T17:51:38Z

socialhome/views.py

+        token, created = Token.objects.get_or_create(user=user)
+        data = LimitedProfileSerializer(user.profile, context={"request": self.request}).data
+        data.update({"token": token.key})
+        print(data)


Print should be removed.

Ah, missed this one after finishing to debug. Nice catch.

christophehenry · 2018-03-03T18:08:47Z

Done.

jaywink

Great, thanks! <3

jaywink reviewed Feb 27, 2018

View reviewed changes

jaywink added the in progress label Feb 28, 2018

christophehenry force-pushed the add-user-profile-at-authent branch from c5dffad to 60abba3 Compare February 28, 2018 22:00

jaywink reviewed Mar 2, 2018

View reviewed changes

Add user profile at authentication

dca7d76

christophehenry force-pushed the add-user-profile-at-authent branch from 60abba3 to f67d517 Compare March 3, 2018 11:54

christophehenry changed the title ~~[WIP] Add user profile at authentication~~ [Add user profile at authentication Mar 3, 2018

christophehenry changed the title ~~[Add user profile at authentication~~ Add user profile at authentication Mar 3, 2018

jaywink reviewed Mar 3, 2018

View reviewed changes

Documenting '/api-token-auth/' endpoint

b8dad13

christophehenry force-pushed the add-user-profile-at-authent branch from f67d517 to b8dad13 Compare March 3, 2018 18:08

jaywink approved these changes Mar 3, 2018

View reviewed changes

jaywink merged commit c8a12ff into jaywink:master Mar 3, 2018

jaywink removed the in progress label Mar 3, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add user profile at authentication #447

Add user profile at authentication #447

christophehenry commented Feb 27, 2018 •

edited

codecov bot commented Feb 27, 2018 •

edited

jaywink left a comment

jaywink commented Feb 27, 2018

christophehenry commented Feb 28, 2018

christophehenry commented Mar 1, 2018

jaywink Mar 2, 2018

jaywink Mar 2, 2018

jaywink commented Mar 2, 2018

christophehenry commented Mar 3, 2018

jaywink left a comment

jaywink Mar 3, 2018

jaywink Mar 3, 2018

christophehenry Mar 3, 2018 •

edited

christophehenry commented Mar 3, 2018

jaywink left a comment

Add user profile at authentication #447

Add user profile at authentication #447

Conversation

christophehenry commented Feb 27, 2018 • edited

codecov bot commented Feb 27, 2018 • edited

Codecov Report

jaywink left a comment

Choose a reason for hiding this comment

jaywink commented Feb 27, 2018

christophehenry commented Feb 28, 2018

christophehenry commented Mar 1, 2018

jaywink Mar 2, 2018

Choose a reason for hiding this comment

jaywink Mar 2, 2018

Choose a reason for hiding this comment

jaywink commented Mar 2, 2018

christophehenry commented Mar 3, 2018

jaywink left a comment

Choose a reason for hiding this comment

jaywink Mar 3, 2018

Choose a reason for hiding this comment

jaywink Mar 3, 2018

Choose a reason for hiding this comment

christophehenry Mar 3, 2018 • edited

Choose a reason for hiding this comment

christophehenry commented Mar 3, 2018

jaywink left a comment

Choose a reason for hiding this comment

christophehenry commented Feb 27, 2018 •

edited

codecov bot commented Feb 27, 2018 •

edited

christophehenry Mar 3, 2018 •

edited