Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump openssh to v0.9.0 and enable feature native-mux #17

Merged
merged 4 commits into from Apr 24, 2022
Merged

Bump openssh to v0.9.0 and enable feature native-mux #17

merged 4 commits into from Apr 24, 2022

Conversation

NobodyXu
Copy link
Contributor

@NobodyXu NobodyXu commented Apr 24, 2022 •
edited

Fixed #1

Enabling feature native-mux requires once_cell to be bumped, so I bumped the Cargo.lock using cargo update.

I also disabled default-feature process-mux of openssh, which then requires me to modify src/session.rs to use the new SSHSession::connect_mux API.

openssh v0.9.0 also

  • use openssh::Stdio instead of std::process::Stdio in Command::{stdin, stdout, stderr}.
  • updates API of Command::spawn to an async method.

Signed-off-by: Jiahao XU Jiahao_XU@outlook.com

@NobodyXu
Bump dep openssh to v0.9.0
612e6b9 
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu
Bump Cargo.lock via cargo update
804cab7 
To enable new features of `openssh`, we have to bump version of
`once_cell`.

Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu
Enable feature native-mux for dep openssh
070b8bc 
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu
Disable process-mux feature of openssh
b1162a8 
Modify `Session::connect` to use `SSHSession::connect_mux`.

Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
jaywonchung
jaywonchung approved these changes Apr 24, 2022
View reviewed changes
Copy link
Owner

@jaywonchung jaywonchung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tested it separately, and this works perfectly. LGTM. Thanks for the contribution!

@jaywonchung jaywonchung merged commit 406aa80 into jaywonchung:master Apr 24, 2022
@NobodyXu NobodyXu deleted the bump-openssh-to-v9.0 branch April 25, 2022 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaywonchung jaywonchung jaywonchung approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade to openssh v0.9.0 with native-mux feature?
2 participants
@NobodyXu @jaywonchung