Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Graceful shutdown #3

Closed
jaywonchung opened this issue Feb 4, 2022 · 1 comment · Fixed by #9
Closed

Graceful shutdown #3

jaywonchung opened this issue Feb 4, 2022 · 1 comment · Fixed by #9
Labels
enhancement New feature or request

Comments

@jaywonchung
Copy link
Owner

Currently, Pegasus doesn't handle ctrl-c very well. When the user presses ctrl-c, Pegasus terminates without cancelling the SSH session tasks. So the ssh sessions remain open, .ssh-connection* directories stay as is, and in order to kill the processes spawned on remote nodes, I need to walk into each node and kill them manually.

Potential solutions

  • One method would be to propagate the signal to all child ssh processes. Proper error handling inside the tasks would probably serve as an okay solution.
  • Another method I'd like to explore is to see if using the native-mux feature of the coming openssh crate will make graceful shutdown any easier.
@jaywonchung jaywonchung added the enhancement New feature or request label Feb 4, 2022
@jaywonchung
Copy link
Owner Author

Also, for the current daemon mode, there is no way to gracefully terminate.

@jaywonchung jaywonchung mentioned this issue Feb 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Graceful shutdown on ctrl-c jaywonchung/pegasus
1 participant
@jaywonchung